Collector makes you the most money the fastest.
It is simple, all you need is the shovel, metal detector and the role, each collection is worth a different amount of money, the coins for exampel are 540.00 for a full set, and I think 1400 xp? or maybe 140 xp I forget.,
Well I had 6 full sets of coins and except for one coin, 9 full sets, same with every collectible category, I plan to sell them all after I get the new role so I can use that xp towards the pass.
Collector will make you the most money, the trader is good as a passive background money making business, same as the moonshiner.